Add sub value to output access tokens - #92
Merged
Merged
Conversation
joachimvh
force-pushed
the
feat/token-sub
branch
from
July 13, 2026 11:06
3832454 to
dc37f0a
Compare
Collaborator
|
Is this now the default behavior? I have a slight preference for keeping it an option that has to be configuredsl explicitly... |
Contributor
Author
|
I'll have a look if I can make it be optional in the same way as the partial permissions |
joachimvh
force-pushed
the
feat/token-sub
branch
from
July 15, 2026 06:22
e283a22 to
298e03b
Compare
joachimvh
force-pushed
the
feat/partial-result
branch
2 times, most recently
from
July 27, 2026 08:08
b4b7937 to
7155ac4
Compare
joachimvh
force-pushed
the
feat/token-sub
branch
from
July 27, 2026 08:19
298e03b to
2e104e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also a potential "for now" solution. This couples the RS and AS a bit more, and perhaps too much. In the future we might instead want to return a more opaque value there which stays the same for the same input identity, but does not leak the actual identity. Depends a bit on the use case being solved.