Updates to remove JMS references and replace with Jakarta Messaging - #188
Closed
HariRangarajan-Solace wants to merge 8 commits into
Closed
HariRangarajan-Solace wants to merge 8 commits into
HariRangarajan-Solace wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The shared API fragment breaks non-JMS tutorials, and the delivery documentation incorrectly excludes asynchronous sends.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Migrates JMS tutorials and sample references to Jakarta Messaging 3.1.
Changes:
- Updates terminology, documentation links, and sample paths.
- Points tutorials to the Jakarta Messaging sample repository.
- Adds Gradle and Maven dependency instructions.
| File | Description |
|---|---|
using-jndi.md |
Updates JNDI terminology and sample links. |
using-external-jndi.md |
Migrates external JNDI guidance and links. |
tutorials.yml |
Renames the tutorial collection and repository. |
topic-to-queue-mapping.md |
Updates Jakarta Messaging terminology. |
request-reply.md |
Migrates request/reply documentation and samples. |
publish-subscribe.md |
Updates API references and sample instructions. |
persistence-with-queues.md |
Migrates persistent messaging guidance. |
confirmed-delivery.md |
Updates delivery confirmation documentation. |
common-assets/solaceApi.md |
Adds Jakarta JMS dependency instructions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mrc0113
approved these changes
Sep 30, 2026
Mrc0113
left a comment
Contributor
There was a problem hiding this comment.
Looks good to merge to me. Let's await product review to make sure the naming is correct.
added 6 commits
October 1, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes include :