LAB- 1957 Updating endpoints - #154
Merged
Merged
Conversation
Changing deploy-related endpoints to reflect changed payloads and object structures
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SHIELD deploy-related OpenAPI schemas to reflect changed request/response payload structures and bumps the Shield TypeScript SDK/spec versions accordingly.
Changes:
- Bump Shield SDK/package versions from
3.3.0to3.4.0(package.json, package-lock.json, SHIELD spec info.version). - Update
GET /Api/Deployresponse schema to replacedeployTagIncludewithrequestedConfigItems. - Update deploy request payloads to replace the prior
includeflag withconfigIdListarrays and adjust required fields/examples.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shield/TypeScript/package.json | Version bump to 3.4.0 for the Shield TypeScript SDK. |
| src/shield/TypeScript/package-lock.json | Lockfile version bump to 3.4.0 to match package.json. |
| specs/SHIELD.json | OpenAPI version bump + deploy endpoint payload/schema updates (remove deployTagInclude/include, add requestedConfigItems/configIdList). |
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updating description and example following comments
Pasha Zayko (pasha-zayko)
requested review from
Elliot Huffman (elliot-huffman) and
pr0uxx
April 20, 2026 16:46
pr0uxx
approved these changes
Apr 21, 2026
Contributor
|
Elliot Huffman (@elliot-huffman) requires sec review |
Elliot Huffman (elliot-huffman)
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing deploy-related endpoints to reflect changed payloads and object structures