dotnet tests: a wrong DOTNET_E2E_* path fails instead of skipping - #62
Merged
Merged
Conversation
Five E2E test classes each carried the same binary lookup, and each returned null -- "no binaries, skip" -- when a DOTNET_E2E_* variable was set but named a file that did not exist. The tests treat null as a local run and return early, so a mistyped or not-yet-built path in CI turned the whole real-binary suite into a green no-op. That is the trap the Go agent E2E suite fell into on Windows until #60, and CLAUDE.md listed the .NET half as still open. The five copies now share E2EBinaries.Sources(): both variables unset still skips, as a local run should; one set without the other, or either naming a missing file, throws with the variable and path. CLAUDE.md says so in place of the "still goes quiet" note. Verified: E2EBinariesTests pin all three outcomes. dotnet test dotnet/Meowshell.sln passes 231/231 with the variables unset, and 231/231 against the real linux_amd64 binaries with e2e/start-testderp.sh running, as CI runs it. With DOTNET_E2E_MEOWSHELL_BIN pointed at a missing file, 26 real-binary tests fail with "does not exist"; before this change the same configuration passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WM5HyhwRLKBDyHR6qitkk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A mistyped or not-yet-built binary path in CI made the .NET real-binary E2E suite pass without running anything.
DOTNET_E2E_*variable was set but named a file that doesn't exist.Fix
E2EBinaries.Sources().Verification
E2EBinariesTestscovers all three outcomes (skip, run, throw).dotnet test dotnet/Meowshell.slnpasses 231/231.linux_amd64binaries, withe2e/start-testderp.shrunning as in CI.DOTNET_E2E_MEOWSHELL_BINpointed at a file that doesn't exist, 26 real-binary tests fail with "does not exist". Before this change, the same configuration passed.🤖 Generated with Claude Code
https://claude.ai/code/session_013WM5HyhwRLKBDyHR6qitkk
Generated by Claude Code