[WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M by laity-w-sudo · Pull Request #3194 · SmartThingsCommunity/SmartThingsEdgeDrivers

laity-w-sudo · 2026-08-25T08:45:58Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding the air pressure function to the SNZB-02M equipment

Summary of Completed Tests

github-actions · 2026-08-25T08:46:28Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-08-25T08:46:29Z

Profile category check: ✅ Passed - all profiles have a category defined.

github-actions · 2026-08-25T08:47:06Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/qyMZQQwZPjmY

github-actions · 2026-08-25T08:48:03Z

Test Results

73 files ±0 542 suites +1 0s ⏱️ ±0s
3 267 tests +3 2 822 ✅ - 442 0 💤 ±0 1 ❌ +1 444 🔥 +444
5 256 runs +3 4 667 ✅ - 586 0 💤 ±0 1 ❌ +1 588 🔥 +588

For more details on these failures and errors, see this check.

Results for commit 494c68c. ± Comparison against base commit f46b647.

♻️ This comment has been updated with latest results.

github-actions · 2026-08-25T08:48:07Z

zigbee-humidity-sensor_coverage.xml

File	Coverage
All files	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/frient-sensor/air-quality/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/sonoff/SNZB-02M/init.lua	`90%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 494c68c

The SNZB-02M sub-driver was added but never registered, so the pressure display feature was dead code on the device. Register it via sub_drivers.lua, drop the unrelated SNZB-02LD/WD handler and utils (not in this driver, and referencing a nonexistent sub-driver), and add unit tests for pressure conversion and refresh. Co-Authored-By: Claude <noreply@anthropic.com>

KKlimczukS · 2026-08-31T09:13:59Z

@@ -0,0 +1,12 @@
+-- Copyright 2025 SmartThings, Inc.


Suggested change

-- Copyright 2025 SmartThings, Inc.

-- Copyright 2026 SmartThings, Inc.

KKlimczukS · 2026-08-31T09:15:04Z

+--[[
+Description: SNZB-02M pressure/humidity/temperature sensor driver
+Version: 1.0
+Author: GitHub Copilot
+--]]


Suggested change

--[[

Description: SNZB-02M pressure/humidity/temperature sensor driver

Version: 1.0

Author: GitHub Copilot

--]]

-- Copyright 2026 SmartThings, Inc.

-- Licensed under the Apache License, Version 2.0

KKlimczukS · 2026-08-31T09:17:32Z

+  if raw_value > 2000 then
+    return raw_value / 1000.0
+  end


Please, could You add short explanation (in a comment) above this "if" statement regarding the edge case that forces this division ?

@laity-w-sudo How come this change was removed ? Did You change anything on device's firmware ?

KKlimczukS · 2026-08-31T09:19:25Z

+if CHANGED_DRIVERS:
+  DRIVERS = [driver for driver in DRIVERS if driver.name in CHANGED_DRIVERS]


This change is not directly related to Your device.

cjswedes · 2026-08-31T14:42:10Z

Remove the changes to this file.

KKlimczukS · 2026-09-01T12:21:54Z

+  - id: refresh
+    version: 1
+  categories:
+  - name: MultiFunctionalSensor


Suggested change

- name: MultiFunctionalSensor

- name: HumiditySensor

@laity-w-sudo this requested change is mandatory

KKlimczukS · 2026-09-03T07:04:52Z

@@ -0,0 +1,117 @@
+-- Copyright 2025 SmartThings, Inc.


Suggested change

-- Copyright 2025 SmartThings, Inc.

-- Copyright 2026 SmartThings, Inc.

KKlimczukS · 2026-09-03T07:05:24Z

   lazy_load_if_possible("centralite-sensor"),
   lazy_load_if_possible("heiman-sensor"),
   lazy_load_if_possible("frient-sensor"),
+   lazy_load_if_possible("sonoff.SNZB-02M"),


Please remove the comma at the end of line

Please remove the comma at the end of line

Hi, the modifications have been made according to your suggestions. However, due to the changes, the automated production line test has failed at present. How can we solve this problem? Also, the error message seems to have nothing to do with the driver I submitted.

Add the pressure display function to SNZB-02M

1f3d8bb

laity-w-sudo force-pushed the main branch 2 times, most recently from ae161d5 to b5e3665 Compare August 25, 2026 11:23

laity-w-sudo added 3 commits August 25, 2026 20:20

Fix SNZB-02M lazy-load and pressure test

46e746d

Load-SNZB-02M-handlers-during-lazy-load

0909220

Limit-parallel-driver-tests-to-changed-drivers

1ca26b1

KKlimczukS reviewed Aug 31, 2026

View reviewed changes

KKlimczukS requested a review from cbaumler August 31, 2026 09:20

KKlimczukS changed the title ~~Add the pressure display function to SNZB-02M~~ [WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M Aug 31, 2026

cbaumler requested review from aleclorimer and cjswedes August 31, 2026 14:35

cjswedes requested changes Aug 31, 2026

View reviewed changes

Comment thread tools/run_driver_tests_p.py

cjswedes Aug 31, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changes to this file.

KKlimczukS requested changes Sep 1, 2026

View reviewed changes

laity-w-sudo requested a review from KKlimczukS September 3, 2026 03:25

laity-w-sudo added 2 commits September 3, 2026 11:36

Merge branch 'SmartThingsCommunity:main' into main

7780cd9

Modify the relevant contents of SNZB-02M according to the suggestions

b7123f5

KKlimczukS reviewed Sep 3, 2026

View reviewed changes

laity-w-sudo requested review from KKlimczukS and cjswedes September 4, 2026 02:18

Modify the relevant contents of SNZB-02M according to the suggestions

494c68c

	-- Copyright 2025 SmartThings, Inc.
	-- Copyright 2026 SmartThings, Inc.

		if CHANGED_DRIVERS:
		DRIVERS = [driver for driver in DRIVERS if driver.name in CHANGED_DRIVERS]

Uh oh!

Conversation

laity-w-sudo commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

laity-w-sudo commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading