Default handler missing log require patch#3101
Open
aleclorimer wants to merge 1 commit into
Open
Conversation
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 04c3de6 |
varzac
approved these changes
Jul 8, 2026
cjswedes
approved these changes
Jul 8, 2026
cjswedes
left a comment
cjswedes
left a comment
Contributor
There was a problem hiding this comment.
When we do a monkey patch like this to fix a driver with something a future lua libs will have fixed, I think we should include a comment about why it is included, and when it is okay to remove it from the driver so that it is easier to maintain in the future if were looking at it.
Contributor
Author
If we choose to go this route ill update with a comment with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick patch of a missing require in the lua libs requiring some zigbee-switch drivers to crash. Coppied over the fixed/updated default handler for powerMeter instantaneous demand.