fix: recover early provider stream disconnects - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A prematurely closed chunked HTTP response raises
RemoteProtocolErrorand previously ended the turn immediately. Reproduced the exact incomplete-chunked-read failure with a local HTTP server. This change recovers early failures and adds evidence for upstream investigation; it does not establish why the upstream connection closed.Validation
pytest -q tests/test_transport.py tests/test_providers.py tests/test_codex.py tests/test_agent.py— 59 passedruff check src/ava/transport/http.py tests/test_transport.py— passedmypy src/ava/transport/http.py— passedgit diff --check— passedSocket-level tests cover recovery, retry exhaustion, no replay after metadata/terminal events, truncated HTTP error responses, cancellation during backoff, and diagnostic privacy.
Limitation
Once any SSE event has been delivered, interrupted streams still fail rather than automatically retry. Even metadata can mutate adapter state. An early retry can also repeat upstream generation and incur additional provider cost.