Skip to content

refactor: remove legacy conversion subsystem - #109

Merged
SkyeAv merged 5 commits into
mainfrom
delete-legacy-converter
Aug 21, 2026
Merged

refactor: remove legacy conversion subsystem#109
SkyeAv merged 5 commits into
mainfrom
delete-legacy-converter

Conversation

@SkyeAv

@SkyeAv SkyeAv commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Removes the legacy TableConfigs-to-v12 conversion subsystem because it is too difficult to maintain. Current v12 workflows and unrelated compatibility behavior remain intact.

Converter Removal

  • Implementation: Deletes src/tablassert/legacy.py, its tests, fixtures, CLI command, and converter-specific errors/codes.
  • CLI surface: Leaves exactly five commands; convert-legacy now fails with an unknown-command error.
  • Documentation: Removes converter guidance from docs/cli.md and docs/agent.md.

Design

  • Intentional break: Legacy configs no longer have an in-project conversion path; existing v12 configs remain supported.
  • Compatibility: Fullmap compatibility, rig-legacy-keys, relationship_strength, and retained legacy data paths are unchanged.
  • Scope: 13 intended paths changed; no dependency, Rust, CI, Makefile, or changelog changes.

Testing

  • uv run pytest -q930 passed, 37 skipped
  • Focused docs/error/assembly tests → 23 passed, 3 skipped
  • Boundary compatibility tests → 4 passed
  • uv run ruff check . → passed
  • uv run ruff format --check . → 75 files formatted
  • uv run pyright → 0 errors
  • Converter-token and deleted-module sweeps → zero matches
  • Independent whole-diff audit → PASS

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3bdd1b04-e1c7-4309-9bbb-35ddd234f18d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SkyeAv
SkyeAv merged commit 58787f4 into main Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant