Use tenant specific endpoint - #1
Open
zuhairmahd wants to merge 5 commits into
Open
Conversation
Placed there while I was testing
Author
|
@SkipToTheEndpoint Thanks for an interesting idea. I took it for a spin and realized that the documentation had a couple of issues:
Thanks again. |
zuhairmahd
marked this pull request as ready for review
August 30, 2025 13:12
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the authentication configuration to support both single-tenant and multi-tenant Entra ID scenarios by introducing new environment variables and improving backward compatibility.
- Added support for tenant-specific authentication endpoints using
VITE_ENTRA_TENANT_ID - Implemented backward compatibility for existing
VITE_CLIENT_IDenvironment variable - Updated documentation to reflect new environment variable usage and configuration options
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/config.js | Updated MSAL configuration to use new environment variables with fallback logic |
| README.md | Updated documentation to explain new environment variables and their usage |
| CNAME | Added empty CNAME file for deployment configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Remove CNAME Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the authentication configuration to support both single-tenant and multi-tenant Entra ID (Azure AD) scenarios, improves environment variable flexibility, and updates documentation for clarity. It also adds a new CNAME for deployment.
Authentication configuration and environment variables:
src/utils/config.jsto useVITE_ENTRA_CLIENT_IDas the primary client ID, withVITE_CLIENT_IDas a fallback for backward compatibility. The authority URL now usesVITE_ENTRA_TENANT_IDif set, enabling single-tenant support, or defaults tocommonfor multi-tenant.Documentation updates:
README.mdto reflect the new environment variables, clarifying the use ofVITE_ENTRA_CLIENT_ID,VITE_ENTRA_TENANT_ID, and the optionalVITE_CLIENT_IDfor backward compatibility. The documentation now explains the purpose of each variable and when to use them. [1] [2]