Repository navigation
Conversation
On main, infra/fixtures/agentic_scenarios.py does not parse: it holds two
module docstrings, and test collection stops with a SyntaxError. And
templates/partials/result_rep_panel.html has an {% endif %} that closes
nothing, so every page that includes the panel raises TemplateSyntaxError.
Both files go back to their content on the agentic demo branch at
297e4b9. The fixture is that file verbatim. In the panel, the
deterministic-checks list and the no-spans {% else %} branch, which that
branch had removed, are dropped again; the evidence-link script and the
HTML-comment conversion already on main are kept. No other line changes.
Author
|
Superseded by #58, which fixed the template on main. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files are broken on main
e8b5168:infra/fixtures/agentic_scenarios.pydoes not parse: it contains two module docstrings. Test collection stops oninfra/tests/test_agentic_demo_pack.pywith aSyntaxError.templates/partials/result_rep_panel.htmlhas an{% endif %}that closes nothing, so every page that includes the panel raisesTemplateSyntaxError(scenario result detail, the public result page, the page smoke test).Both are restored from #55's branch as it stood at
297e4b9. The fixture is that file verbatim. In the panel, the deterministic-checks list and the no-spans{% else %}branch, which #55 had removed, are removed again; the evidence-link script and the HTML-comment conversion already on main stay. Nothing else changes: the diff contains only deletions.Tested
Full suite as CI selects it (
-m "not embedded_hatchet", run serially, Python 3.12,uv sync --frozen --extra dev):e8b5168: 1257 passed, 13 failed, 1 collection error.Still failing with this branch:
audits/agentic/tests/test_evaluate.py::test_retrieval_source_unresolvable_file_is_inconclusive_without_listinginfra/tests/test_agentic_result_ui.py::AgenticResultPageRenderTests::test_blocks_self_hide_without_agentic_datainfra/tests/test_agentic_result_ui.py::AgenticResultPageRenderTests::test_finding_cards_jump_to_evidence_spansinfra/tests/test_agentic_result_ui.py::AgenticResultPageRenderTests::test_judge_panel_hides_without_semantic_judgementinfra/tests/test_verify_agentic_audit.py::VerifyAgenticAuditTests::test_local_runtime_harness_checks_correlation_and_judge_orderinfra/tests/test_verify_agentic_audit.py::VerifyAgenticAuditTests::test_verification_command_executes_fixture_and_evaluator_checksThe two
test_verify_agentic_audittests pass on main and fail here:verify_agentic_audit'sui-evidence-linkingcheck looks forcheck.evidence_span_idsin the panel source, and only the removed checks list contained it. Five of the six also fail on297e4b9; the sixth,test_blocks_self_hide_without_agentic_data, finds "Semantic judge" in the<!-- Semantic judge dimensions -->comment already on main.AI disclosure: implemented with Claude Code.