[3.0] Theme split (wave 4, part 26) — point the drop menu submenus at design tokens - #9468
Merged
live627 merged 2 commits intoAug 10, 2026
Merged
Conversation
Follows the level 1 buttons: the level 2 and 3 submenu wrapper, the items inside it and their hover state were the rest of the hard-coded colours in the drop menu rules. Every token holds the value the rule has today, so nothing renders differently. The wrapper deliberately sets a border and then overrides the left and top edges with lighter colours, so those keep their own tokens rather than being flattened, and all three stay shorthands. Signed-off-by: Mathias Albert <mathiaspapealbert@hotmail.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 9, 2026
Closed
…enu-tokens Signed-off-by: albertlast <mathiaspapealbert@hotmail.com> # Conflicts: # Themes/default/css/variables.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the #7933 split, and the other half of #9467. That one did the level 1 buttons; this does the level 2 and 3 submenu wrapper, the items inside it, and their hover state — the rest of the hard-coded colours in the drop menu rules.
20 tokens in
/** Drop Menu Submenus **/and/** Drop Menu Submenu Items **/. Every token holds the value the rule has today, so nothing renders differently.The wrapper deliberately sets a border and then overrides the left and top edges with lighter colours:
so those edges keep their own tokens rather than being flattened, and all three stay shorthands.
.dropmenu li li a:hoverdoes the same thing and is treated the same way.Verification
0 differences, by two independent methods:
ul.dropmenu > li > ul > li > abuilt on the board index, 5 elements, 32 computed longhands each — 160 values, 0 differences.index.cssfetched over HTTP and its rule bodies applied to a probe in cascade order, to reach the:hoverstates a script cannot trigger — 160 values, 0 differences.The second method exists because of a trap worth flagging for anyone reviewing this kind of change. Reading rule text back out of
CSSRule.style.cssTextand replaying it cannot round-trip abordershorthand that holds avar()and is then overridden on one edge. Doing it that way reported 21 confident-looking differences here — right and bottom borders collapsing to0px none currentColor— none of which are real. The rule text has to come from the file, or the measurement has to be taken on a real element.This touches
variables.cssat the same place as #9467, so whichever lands second needs a trivial rebase. Both insert next to/** Main Menu **/rather than at the end of the file, so neither collides with #9443 or #9448.Issues References (Fixes|Related|Closes)
Related: #7933, #9467