Repository navigation
Name the collections in the MaxSingleQueryCollections message - #50
Merged
Merged
Conversation
A query over the level only said how many collections it loaded side by side, so the developer had to read the query to find which Include to move to a query of its own. The violation now carries the collections, in query order, named as the entity they are from and the navigations to them, and the message and log line list them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A query over
MaxSingleQueryCollectionsonly said how many collections it loaded side by side, so the developer had to read the query to find whichIncludeto move to a query of its own.The violation now carries the collections in query order, each named as the entity it is from and the navigations to it, and the exception message and log line list them:
CollectionCounterreturns the counted collections' names rather than a count. Includes are visited source first so they come out in query order. A nested chain is named by the collection at its end; projected collections are named too, and a projected subquery asDbSet<T>.QueryComplexityViolation.Collectionsexposes the list, null for every other level.The rule itself is unchanged.