refactor: remove Nix support#623
Merged
Merged
Conversation
The Nix flake-based build and development environment is no longer maintained, so remove it along with its CI job: - delete flake.nix, flake.lock, and the direnv .envrc - delete the 'Nix' GitHub Actions workflow (.github/workflows/nix.yml) - drop the .direnv and result ignore entries and IDE exclude folders
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 31 31
Lines 2612 2612
=======================================
Hits 2007 2007
Misses 605 605 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes the unmaintained Nix flake-based build/development environment and its CI job.
Changes
flake.nixandflake.lock— the Nix flake defining the build/dev shell..envrc(use flake) — the direnv shim that loaded the flake..github/workflows/nix.yml— the "Nix" workflow that rannix build .#andnix flake check..gitignore— dropped the/.direnvand/resultentries (Nix/direnv build artifacts)..idea/github-backup.iml— removed the.direnvandresultexclude-folder entries.Not touched (intentionally unrelated to Nix-the-package-manager)
Cargo.lock— thenixcrate (v0.31.3) is a transitive Rust dependency providing Unix syscall bindings, not related to the Nix package manager.examples/config.yamlandtests/data/*— references to anix-envrepository /Nixlanguage are example/fixture data.Notes for reviewers
nix.yml) is configured as a required check in branch protection, it should be removed from the required set after this merges, otherwise PRs will wait on a check that no longer runs.