Support N-1 for outage on PST with PTDF networks - #312
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical issues remain in the parallel-branch correction logic and a test expression.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds PTDF N-1 support for phase-shifting transformer outages, with validation updates and regression tests.
Changes:
- Adjusts PTDF post-contingency flows for removed phase-shift injections.
- Updates DCP/DCPLL validation behavior.
- Adds static, controlled, parallel, and monitored-outage tests.
- Relocates a runtime helper without behavioral changes.
File summaries
| File | Summary |
|---|---|
test/test_phase_control.jl |
Adds phase-shifter outage regression coverage. |
src/operation/template_validation.jl |
Updates DCP/DCPLL validation behavior. |
src/event_models/event_runtime.jl |
Relocates a helper without behavioral change. |
src/ac_transmission_models/security_constrained_branch.jl |
Implements PTDF outage shift adjustments. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+569
to
+574
| # A monitored arc that loses a shifted member also loses that member's share of | ||
| # its own `-b·α` flow offset. | ||
| own = adj.arc == rep.arc ? -1.0 : 0.0 | ||
| for t in time_steps | ||
| JuMP.add_to_expression!(expressions[t], sensitivity + own, adj.delta[t]) | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This case (controlled transformer in parallel with another branch) is disallowed.
|
Performance Results
|
m-bossart
force-pushed
the
mb/n-1-pst
branch
from
September 18, 2026 20:42
6859257 to
f17b0a7
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jd-lara
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will require Sienna-Platform/PowerNetworkMatrices.jl#370 for tests to pass