support AI Agent execution in on-prem and hybrid environments and - #476
Merged
Merged
Conversation
… handleAgentDecisionStreamResult
…p name and tool name validation
…ter request handling
…rt for non-cloud environments
This reverts commit 32b584a.
frikky
reviewed
Sep 10, 2026
frikky
left a comment
frikky
left a comment
Member
There was a problem hiding this comment.
A few things:
- Timeout edgecases will be a nightmare if we enforce it
- The "Hybrid" also sounds like issues, as I don't see why it's necessary. I can't understand when or how the Agent itself is hybrid
Check comments (:
| //ExecutionDelay: selectedDelay, | ||
| timeout := time.Duration(30) * time.Second | ||
| toolTimeout := 120 | ||
| if v := os.Getenv("AGENT_TOOL_TIMEOUT"); len(v) > 0 { |
| baseUrl := "https://shuffler.io" | ||
| baseUrl := "http://localhost:5001" | ||
| if project.Environment == "cloud" { | ||
| baseUrl = "https://shuffler.io" |
Member
There was a problem hiding this comment.
Uhm, do we pass in CLOUDRUN URL as well? shuffler.io is only used for the main region, and the actual correct one is uk.shuffler.io
And for localhost:5001. That's the default port only, passed by PORT env.
|
|
||
| log.Printf("[HEYOOO-PARSED] ParsedExecutionResult: Label='%s', AppName='%s', ActionName='%s', isAgentHybrid=%t, ResultPreview=%.150s", actionResult.Action.Label, actionResult.Action.AppName, actionResult.Action.Name, isAgentHybrid, actionResult.Result) | ||
|
|
||
| if isAgentHybrid && actionResult.Status != "SKIPPED" { |
Member
There was a problem hiding this comment.
I'm not sure I understand "isAgentHybrid"..?
What is the point of this? The agent itself wouldn't be hybrid? That just runs wherever the backend is. The actions it takes however, can be hybrid
| foundApp = &foundApps[0] | ||
| } | ||
| if foundApp.ID == "" { | ||
| algoliaApp, err := HandleAlgoliaAppSearch(ctx, cleanName) |
Member
There was a problem hiding this comment.
Did we validate whether Algolia checks if it's cloud?
Backend onprem doesn't have Algolia access
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.