Share reflected method parameter compilation - #2689
Open
Morriar wants to merge 1 commit into
Open
Conversation
vinistock
approved these changes
Jul 30, 2026
KaanOzkan
reviewed
Jul 31, 2026
| when :block | ||
| RBI::BlockParam.new(name) | ||
| else | ||
| Kernel.raise "Unknown type `#{type}`." |
Contributor
There was a problem hiding this comment.
TIL, agent found that :nokey is a valid parameter kind for: def foo(*args, **nil). Apparently it's used to reject kwargs. It's not supported in rbi but Sorbet doesn't support it either so not raising might be enough.
Member
There was a problem hiding this comment.
There will also be a :noblock version of it in Ruby 4.1: ruby/ruby@9967418
def foo(*args, &nil) = 42
method(:foo).parameters # => [[:rest, :args], [:noblock]]
paracycle
approved these changes
Jul 31, 2026
Comment on lines
+106
to
+108
| fallback_name = "_arg#{index}" | ||
| name ||= fallback_name | ||
| name = fallback_name unless valid_parameter_name?(name) |
Member
There was a problem hiding this comment.
It seems we are allocating a fallback_name unnecessarily for each parameter here. Can we also refactor valid_parameter_name? to accept a String? and reject nil values, so that we can do:
Suggested change
| fallback_name = "_arg#{index}" | |
| name ||= fallback_name | |
| name = fallback_name unless valid_parameter_name?(name) | |
| name = "_arg#{index}" unless valid_parameter_name?(name) |
This way the new string allocation will only happen for invalid or missing parameter names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize reflected parameter name sanitization and
RBI::Paramconstruction inRBIHelperand reuse the helper from DSL and gem method compilation.