Skip to content

Register resume and revert DML listeners before binlog parsing - #68

Merged
coding-chimp merged 1 commit into
masterfrom
fix-resume-listener-order
Nov 9, 2026
Merged

coding-chimp merged 1 commit into
masterfrom
fix-resume-listener-order

Conversation

@grodowski

Copy link
Copy Markdown
Member

Refs github#1793.

Ports the upstream PR #1794. Additional tests use distinct names to avoid upstream collisions and cover queue backpressure, GTID/file coordinates, and github#1790 transaction-marker safeguards.

Resume and revert replay a checkpoint backlog against rows already in the target table. Register the original-table listener and its transaction-completion listener before InitDBConnections starts the parser, so table filtering cannot silently discard pending changes. Remove the later duplicate registrations while preserving fresh migration startup ordering to avoid blocking GhostTableMigrated on a full apply queue.

Keep the applied-transaction watermark, FIFO marker delivery, and context-aware cancellation safeguards unchanged. Add deterministic resume/revert tests in GTID and file-position modes with 3,000 updated rows plus insert/delete changes queued before startup. Validate full row sets, exactly-once listeners/DML, queue saturation, and applied transaction progress.
@grodowski
grodowski force-pushed the fix-resume-listener-order branch from 06c5135 to 1e710af Compare November 6, 2026 10:58
@coding-chimp
coding-chimp merged commit 0ff4f90 into master Nov 9, 2026
14 checks passed
@coding-chimp
coding-chimp deleted the fix-resume-listener-order branch November 9, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants