Repository navigation
Register resume and revert DML listeners before binlog parsing - #68
Merged
Merged
Conversation
coding-chimp
approved these changes
Nov 6, 2026
Resume and revert replay a checkpoint backlog against rows already in the target table. Register the original-table listener and its transaction-completion listener before InitDBConnections starts the parser, so table filtering cannot silently discard pending changes. Remove the later duplicate registrations while preserving fresh migration startup ordering to avoid blocking GhostTableMigrated on a full apply queue. Keep the applied-transaction watermark, FIFO marker delivery, and context-aware cancellation safeguards unchanged. Add deterministic resume/revert tests in GTID and file-position modes with 3,000 updated rows plus insert/delete changes queued before startup. Validate full row sets, exactly-once listeners/DML, queue saturation, and applied transaction progress.
grodowski
force-pushed
the
fix-resume-listener-order
branch
from
November 6, 2026 10:58
06c5135 to
1e710af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs github#1793.
Ports the upstream PR #1794. Additional tests use distinct names to avoid upstream collisions and cover queue backpressure, GTID/file coordinates, and github#1790 transaction-marker safeguards.