feat(layout): provide column index using useColumnIndex hook - #2518
Draft
mdjastrzebski wants to merge 1 commit into
Draft
mdjastrzebski wants to merge 1 commit into
mdjastrzebski wants to merge 1 commit into
Conversation
Author
|
I have signed the CLA! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1838
Adds
useColumnIndex()to@shopify/flash-list. It returns the zero-based column of an item in grid and masonry layouts. In masonry,index % numColumnsgives the wrong column due to item arrangement optimisation.Investigated adding this a param to
renderItembut that resulted in additionalrenderItemcalls, when just the columnIndex changed. In sample check, with 2 column masonry layout it increased the renderItem calls from 14 => 22.Reviewers’ hat-rack 🎩
yarn test --forceExit: new tests cover linear, grid (spans,numColumnschanges) and masonry (column changes after measurement without re-runningrenderItem)0should be the rightmost columnScreenshots or videos (if needed)
N/A: no visual changes.