[Performance] Memoize globalCLIVersion#8063
Conversation
Introduce memoization for the `globalCLIVersion` function to avoid redundant subprocess calls and file system lookups. By using a promise-based cache, we also prevent potential race conditions when the function is called concurrently. Performance impact: - Replaces expensive `captureOutput` and `which.sync` calls with a cached promise after the first execution. - Reduces CPU and I/O usage in high-frequency paths that check for the global CLI version.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/version.d.ts@@ -11,6 +11,10 @@ export declare function localCLIVersion(directory: string): Promise<string | und
* @returns The version of the CLI if it is globally installed or undefined.
*/
export declare function globalCLIVersion(): Promise<string | undefined>;
+/**
+ * Resets the memoized value for the global CLI version.
+ */
+export declare function _resetGlobalCLIVersionCache(): void;
/**
* Returns true if the given version is a pre-release version.
* Meaning is a , , or version.
|
1 participant
Why is this changes needed?
The
globalCLIVersionfunction performs relatively expensive operations, including searching for theshopifybinary in the PATH and spawning a subprocess to get its version. These operations can be a bottleneck if the function is called multiple times during a single command execution.How to test your changes?
CI
Post-deployment steps
None.
PR created automatically by Jules for task 11802952689168992370 started by @gonzaloriestra