Skip to content

[Tests] Add unit tests for flushPromises utility#8062

Merged
gonzaloriestra merged 1 commit into
mainfrom
tests-flush-promises-utility-10896329056256182399
Jul 13, 2026
Merged

[Tests] Add unit tests for flushPromises utility#8062
gonzaloriestra merged 1 commit into
mainfrom
tests-flush-promises-utility-10896329056256182399

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The flushPromises utility in @shopify/cli-kit was identified as lacking dedicated unit tests. Adding these tests ensures the utility correctly handles various asynchronous scenarios, making the codebase safer to change.

WHAT is this pull request doing?

Introduces packages/cli-kit/src/public/node/promises.test.ts which tests:

  • Simple microtasks completion.
  • Chained/nested microtasks completion.
  • Macrotasks scheduled via setImmediate.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 10896329056256182399 started by @gonzaloriestra

Adds comprehensive unit tests for the `flushPromises` utility in `@shopify/cli-kit`.
Covers microtasks, nested microtasks, and macrotasks (setImmediate).
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 12, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jul 13, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review July 13, 2026 12:42
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner July 13, 2026 12:42

gonzaloriestra commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 13, 1:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 13, 1:55 PM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 7d6d2df Jul 13, 2026
30 of 31 checks passed
@gonzaloriestra gonzaloriestra deleted the tests-flush-promises-utility-10896329056256182399 branch July 13, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants