Skip to content

Include the cause chain in the wasm bindings' map parse errors. - #9

Open
2Pacalypse- wants to merge 1 commit into
mainfrom
wasm-error-chain
Open

2Pacalypse- wants to merge 1 commit into
mainfrom
wasm-error-chain

Conversation

@2Pacalypse-

Copy link
Copy Markdown
Member

JS only receives the error's string, and ChkExtractionError's messages are just the top level ("Failed to read MPQ"), so a map that exceeded a resource limit failed with failed to parse map: Failed to read MPQ and no hint of which limit. Parse errors now append each source's message, e.g. failed to parse map: Failed to read MPQ: MPQ file bytes limit exceeded: observed …, limit ….

Found while debugging a ShieldBattery map (127 MB CHK) whose thumbnails failed under the default limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant