Repository navigation
Include the cause chain in the wasm bindings' map parse errors. - #9
Open
2Pacalypse- wants to merge 1 commit into
Open
2Pacalypse- wants to merge 1 commit into
2Pacalypse- wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS only receives the error's string, and
ChkExtractionError's messages are just the top level ("Failed to read MPQ"), so a map that exceeded a resource limit failed withfailed to parse map: Failed to read MPQand no hint of which limit. Parse errors now append each source's message, e.g.failed to parse map: Failed to read MPQ: MPQ file bytes limit exceeded: observed …, limit ….Found while debugging a ShieldBattery map (127 MB CHK) whose thumbnails failed under the default limits.