Repository navigation
Conversation
ShieldBattery's app reads SC:R's command card icons (webui/dist/lib/images/cmdicons.*.png) for its hotkey editor, and wants them read through broodcasc rather than a CASC reader of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CascStoragein the WASM bindings only feeds map rendering. This addsreadFile(path), which reads any file out of the install by its catalog path through the same broodcascStorage, returning aUint8Array.ShieldBattery's hotkey editor uses it to show SC:R's command card icons (
webui/dist/lib/images/cmdicons.*.png) read from the player's own install, so the app needs no CASC reader of its own and ships no game art.checked_size).failed to read <path>: <broodcasc error>, includingNotInstalledfor files a partial install catalogs but never downloaded.Tests:
pnpm run test:packagewithBROODMAP_TEST_SCR_DIRset: new install-backed test reads a cmdicons PNG with a mixed-case, backslashed path, checks the cache stays empty and that a missing path throws (10/10 pass).pnpm run test:typescovers the new declaration;pnpm test111/111;cargo clippy -p broodmap-wasm -- -D warningsandcargo fmt --checkclean.Needs a release of
@shieldbattery/broodmapfor ShieldBattery to depend on it.🤖 Generated with Claude Code