Repository navigation
Bump MarkupString to 2.22.1 - #2233
Conversation
Picks up the linear table labels without the heading's padding, so a screen reader hears "Idle: 59s" instead of "Idle : 59s". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015YDiaApsFRN4PnfRwGRp7i
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 19 minutes for your next included review. View limit details
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 797bfd4d91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --> | ||
| <PropertyGroup> | ||
| <MarkupStringVersion>2.22.0</MarkupStringVersion> | ||
| <MarkupStringVersion>2.22.1</MarkupStringVersion> |
There was a problem hiding this comment.
Regenerate the table fixture alongside the renderer bump
The renderer bump leaves tools/responsive-sweep/fixtures/radio-table.html marked as version 2.22.0, so the version assertion in tools/responsive-sweep/table-layout.test.mjs:33 now fails (confirmed by running the targeted Node test). .github/workflows/portal-layout.yml explicitly triggers on Directory.Build.props changes and runs this suite via npm test, so this change breaks the Portal layout check. Regenerate the fixture with the new renderer and update its version marker alongside the dependency.
Useful? React with 👍 / 👎.
$(MarkupStringVersion)2.22.0 → 2.22.1, which brings in SharpMUSH/MarkupString#70. When a table is laid out linearly (for a screen reader or a narrow client), each cell is now labelled by its trimmed heading. A screen reader used to read WHO as "Idle : 59s" and now reads "Idle: 59s".Generated by Claude Code