Skip to content

Bump MarkupString to 2.22.1 - #2233

Merged
HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-i4t2iz-markupstring-2.22.1
Oct 23, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-i4t2iz-markupstring-2.22.1

Conversation

@HarryCordewener

Copy link
Copy Markdown
Member

$(MarkupStringVersion) 2.22.0 → 2.22.1, which brings in SharpMUSH/MarkupString#70. When a table is laid out linearly (for a screen reader or a narrow client), each cell is now labelled by its trimmed heading. A screen reader used to read WHO as "Idle : 59s" and now reads "Idle: 59s".


Generated by Claude Code

Picks up the linear table labels without the heading's padding, so a
screen reader hears "Idle: 59s" instead of "Idle : 59s".

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015YDiaApsFRN4PnfRwGRp7i
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 19 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 57 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: d74addfe-f4dc-4810-81a5-37da9b3a1a39
📥 Commits

Reviewing files that changed from the base of the PR and between d0d4827 and 797bfd4.

📒 Files selected for processing: 1
  • Directory.Build.props
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@HarryCordewener
HarryCordewener marked this pull request as ready for review October 23, 2026 19:53
@HarryCordewener
HarryCordewener merged commit c45cdf9 into main Oct 23, 2026
23 of 24 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T19:54:26.655034Z 797bfd4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 797bfd4d91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Directory.Build.props
-->
<PropertyGroup>
<MarkupStringVersion>2.22.0</MarkupStringVersion>
<MarkupStringVersion>2.22.1</MarkupStringVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate the table fixture alongside the renderer bump

The renderer bump leaves tools/responsive-sweep/fixtures/radio-table.html marked as version 2.22.0, so the version assertion in tools/responsive-sweep/table-layout.test.mjs:33 now fails (confirmed by running the targeted Node test). .github/workflows/portal-layout.yml explicitly triggers on Directory.Build.props changes and runs this suite via npm test, so this change breaks the Portal layout check. Regenerate the fixture with the new renderer and update its version marker alongside the dependency.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants