Skip to content

Add Forged in the Dark, BRP and Ironsworn sheets with Duties providers - #18

Merged
HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-uebao0
Nov 1, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-uebao0

Conversation

@HarryCordewener

Copy link
Copy Markdown
Member

Requested by Grave · project thread

Wave 2 of the sheet systems, on the skeleton from #16. Each sheet has help, config and chargen bridges and a Duties roll provider, follows the same API tree, declares its root as a wizard, no_command attribute entry, and carries a NOTICE.md plus a +help sheet credits topic.

Package Rules Licence
sheet-fitd, duties-fitd 12 actions under 3 attributes, stress, trauma, harm, coin, clocks; d6 pool against a position; +check/resist. Provider pays assists and pushes in stress Blades in the Dark SRD, CC BY 3.0
sheet-brp, duties-brp characteristics, characteristic rolls, 47 skills with base chances and categories, HP/PP; 1d100 for critical/special/success/failure/fumble. Provider treats help as an augment, TRAINED = above base Basic Roleplaying: Universal Game Engine, ORC (notice, attribution, reserved and designated material in NOTICE.md)
sheet-ironsworn, duties-ironsworn 5 stats, health/spirit/supply/momentum/experience, iron vows with ranks and progress; action rolls ({1d6+N,1d10,1d10}), progress rolls Ironsworn SRD, CC BY 4.0

Rewards: FitD coin and stress relief, BRP skill increases and healing, Ironsworn experience and momentum, all through ONDUTIESGRANT and FNDUTIESREWARDS.

Testing

  • Installed every package on a local server (current SharpMUSH main) through api/packages/apply, and played each sheet over telnet as mortal characters: set, meters/stress/harm, +check at each difficulty, private rolls, bad input, keeper-only paths, vows sworn, marked, fulfilled (strong hit and miss) and forsaken, clocks.
  • Called every provider's FNDUTIES* attribute with uargs() (helpers in %<mods>, bad difficulty, unknown trait) and triggered ONDUTIESGRANT for each reward kind; checked the sheet values changed.
  • A mortal can't write the sheet root: &BRPCHARSTR me=99 → #-1 NO PERMISSION TO SET ATTRIBUTE.
  • tools/PackageValidator --strict: PASSED. tools/check-pf2e-navigation.py: PASS.

Generated by Claude Code

@HarryCordewener HarryCordewener self-assigned this Nov 1, 2026
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 35 billable files and costs up to $8.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 16 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: afe3bf2b-22eb-465d-a322-7161e356fd46
Commits

Reviewing files that changed from the base of the PR and between 8faa2db and c533468.

Files selected for processing: 35
  • README.md
  • duties-brp/README.md
  • duties-brp/package.yaml
  • duties-fitd/README.md
  • duties-fitd/package.yaml
  • duties-ironsworn/README.md
  • duties-ironsworn/package.yaml
  • index.yaml
  • sheet-brp-chargen/README.md
  • sheet-brp-chargen/package.yaml
  • sheet-brp-config/README.md
  • sheet-brp-config/package.yaml
  • sheet-brp-help/README.md
  • sheet-brp-help/package.yaml
  • sheet-brp/NOTICE.md
  • sheet-brp/README.md
  • sheet-brp/package.yaml
  • sheet-fitd-chargen/README.md
  • sheet-fitd-chargen/package.yaml
  • sheet-fitd-config/README.md
  • sheet-fitd-config/package.yaml
  • sheet-fitd-help/README.md
  • sheet-fitd-help/package.yaml
  • sheet-fitd/NOTICE.md
  • sheet-fitd/README.md
  • sheet-fitd/package.yaml
  • sheet-ironsworn-chargen/README.md
  • sheet-ironsworn-chargen/package.yaml
  • sheet-ironsworn-config/README.md
  • sheet-ironsworn-config/package.yaml
  • sheet-ironsworn-help/README.md
  • sheet-ironsworn-help/package.yaml
  • sheet-ironsworn/NOTICE.md
  • sheet-ironsworn/README.md
  • sheet-ironsworn/package.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Three more sheet packages on the sheet-d20/sheet-fate skeleton, each with
help, config and chargen bridges and a Duties roll provider:

- sheet-fitd: twelve actions under Insight, Prowess and Resolve, stress,
  trauma, harm, coin and progress clocks. +check rolls a d6 pool against
  a position; +check/resist marks the stress a resistance costs.
  duties-fitd pays assists and pushes in stress. Blades in the Dark SRD,
  CC BY 3.0.
- sheet-brp: characteristics, characteristic rolls and a skill list with
  base chances, hit points and power points. +check rolls 1d100 for
  critical, special, success, failure or fumble. duties-brp treats help
  as an augment. ORC Licensed Material from Basic Roleplaying: Universal
  Game Engine.
- sheet-ironsworn: five stats, health, spirit, supply, momentum,
  experience and iron vows with progress tracks. +check makes action
  rolls, +vow swears, marks, fulfils and forsakes vows. Ironsworn SRD,
  CC BY 4.0.

Each sheet declares its root as a wizard, no_command attribute entry and
carries a NOTICE.md meeting its licence, plus a +help sheet credits topic.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rqqt7SvmwqfPpiD52tHtJw
@HarryCordewener
HarryCordewener force-pushed the claude/project-thread-uebao0 branch from 7685d68 to c533468 Compare November 1, 2026 02:14
@HarryCordewener
HarryCordewener marked this pull request as ready for review November 1, 2026 02:17
@HarryCordewener
HarryCordewener merged commit 9e0a965 into main Nov 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants