[HarryCordewener]

Requested by Grave · project thread

pf2e-remaster 1.4.0 defines its six wiki fact properties itself through wiki_properties: (format 1.17), because SharpMUSH#2226 takes them out of the engine:

• pf2e:level, pf2e:rank: number
• pf2e:tradition: keyword, several; arcane, divine, occult, primal
• pf2e:class: page, several
• pf2e:ancestry: page
• pf2e:source-book: keyword; player core, player core 2, gm core

It also adds title: Pathfinder 2e, which format 1.16 requires, and bumps the version in index.yaml and the README.

Waits on SharpMUSH#2227. CI validates against SharpMUSH main, which supports format 1.16, so validate stays red until #2227 merges. Run against the #2227 branch, PackageValidator --strict passes (pf2e-remaster 1.4.0 (format 1.17, 4725 wiki pages)), and so does tools/check-pf2e-navigation.py.

After merge, the release tag would be pf2e-remaster/v1.4.0.

---

Generated by Claude Code

Summary by CodeRabbit

• New Features
  • Added wiki properties for Pathfinder 2e level, rank, spell tradition, class, ancestry, and source book.
  • Uninstalling removes these properties while preserving existing page facts.
• Documentation
  • Updated package requirements and documentation to reflect the new wiki properties and package title.
• Chores
  • Updated the package version from 1.3.2 to 1.4.0.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Essentials
• Run ID: af882959-d533-4b5e-adb4-edfe7ac92b89

📥 Commits

Reviewing files that changed from the base of the PR and between 2f9b81b and 6f4d235.

📒 Files selected for processing: 4

• README.md
• index.yaml
• pf2e-remaster/README.md
• pf2e-remaster/package.yaml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The PF2e Remaster package updates to manifest format 1.17 and version 1.4.0. Its manifest adds a title and six wiki properties. The package README documents the properties and updated requirements, and the package listings show the new version.

Changes

PF2e package update

Layer / File(s)	Summary
Update package manifest pf2e-remaster/package.yaml	The manifest format changes to 1.17 and the version changes to 1.4.0. It adds the title Pathfinder 2e and six wiki properties.
Document properties and version pf2e-remaster/README.md, README.md, index.yaml	The package README documents the properties and manifest requirement. The package listings report version 1.4.0.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 6f4d2

No actionable package defect is identified; merge remains dependent on the documented SharpMUSH format support.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding PF2e wiki fact properties in version 1.4.0.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[HarryCordewener]

validate fails because it checks against SharpMUSH main, which supports format 1.16. It warns Format 1.17 is newer than this server fully supports (1.16) and Unknown key 'wiki_properties', and strict mode fails on those warnings. The new key comes from SharpMUSH#2227, so there is nothing to fix in this PR. Against the #2227 branch, PackageValidator --strict passes. Re-run validate once #2227 merges.

---

Generated by Claude Code