Repository navigation
Fix last-tab Esc close: AppleScript can't take a literal \x11, build the byte at runtime - #34
Merged
Merged
Conversation
…pleScript perform action "text:\x11" never compiled — AppleScript rejects the literal backslash escape in a string (syntax error -2741), so the last-tab close always fell through to close-tab and left an empty New-tab page. The action now builds the byte with (ASCII character 17), which Ghostty accepts and sends as Ctrl+W, driving the browser's own closeOrShutdown so the pane exits cleanly. Verified against the running Ghostty: bogus actions return false, text:abc returns true, and the concatenated form returns true. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perform action "text:\x11" fails to compile in AppleScript (syntax error -2741 on the backslash), so close_pane always errored and the last-tab Esc close fell back to close-tab, leaving an empty New-tab page. Now the Ctrl+W byte is built with (ASCII character 17), which Ghostty accepts (verified live: returns true).