Document the event pipeline and expose priority constants - #42
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/21-pixel-access-token #42 +/- ##
===============================================================
+ Coverage 67.07% 67.79% +0.72%
Complexity 135 135
===============================================================
Files 30 30
Lines 413 413
===============================================================
+ Hits 277 280 +3
+ Misses 136 133 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
loevgaard
force-pushed
the
fix/21-pixel-access-token
branch
from
September 7, 2026 11:37
f4fa60a to
17cd9c1
Compare
loevgaard
force-pushed
the
fix/22-pipeline-priorities
branch
from
September 7, 2026 11:37
a448cb6 to
5850beb
Compare
loevgaard
force-pushed
the
fix/21-pixel-access-token
branch
from
September 7, 2026 12:03
17cd9c1 to
f7941c5
Compare
loevgaard
force-pushed
the
fix/22-pipeline-priorities
branch
from
September 7, 2026 12:03
5850beb to
f495dfc
Compare
The order of the ten listeners on ConversionsApiEventRaised lived as magic numbers in ten files and was documented nowhere, so integrators could not tell where to hook in or that a late listener may never run. Name the four bands as constants on the event, derive every subscriber priority from them, and document the pipeline with an enrichment example. No priority changes value. Fixes #22
loevgaard
force-pushed
the
fix/21-pixel-access-token
branch
from
September 7, 2026 12:18
f7941c5 to
1d50dd3
Compare
loevgaard
force-pushed
the
fix/22-pipeline-priorities
branch
from
September 7, 2026 12:18
f495dfc to
3bc77c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Problem
The bundle is a pipeline of ten listeners on
ConversionsApiEventRaisedwhose order lived as magic numbers spread across ten files, documented nowhere. An integrator could not tell that a listener at the default priority is the intended place to enrich the event, that everything is already populated by then, or that a listener below -850 may never run because a filter stopped propagation.Change
No behaviour change. Every priority keeps the exact value it had.
ConversionsApiEventRaisedname the bands:PRIORITY_POPULATE,PRIORITY_ENRICH,PRIORITY_FILTERandPRIORITY_SEND. Every subscriber now derives its priority from them, so there is one source of truth.README.mdgains a How it works section with the full pipeline, the two rules that follow from it, and a worked enrichment listener that attaches the logged-in customer's email, name and external id.Tests
Five unit tests pin the contract down: the pipeline is in descending order, the four populate listeners run above
PRIORITY_ENRICH, the filters and sinks run below it, and the two sinks sit atPRIORITY_SEND.