[Klaud Cold] glm5.2-fp4-b300-sglang-agentic-mtp: GLM-5.2 NVFP4 B300 AgentX with EAGLE MTP and golden-AL synthetic acceptance / 新增 GLM-5.2 NVFP4 B300 SGLang EAGLE MTP AgentX 配置(黄金 AL 合成接受率) - #2447
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
1 similar comment
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
34c8467 to
fcfd122
Compare
| @@ -0,0 +1,288 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
🟡 AGENTS.md line 7 mandates that every PR body follow the English content with a mirrored Chinese translation (e.g. a ## 中文说明 section) — this applies to every PR and issue. This PR's title is bilingual, but the entire body (What's here, MTP, Synthetic acceptance length, Image bump, Search space, Validation) is English-only with no Chinese section.
Extended reasoning...
AGENTS.md line 7 states, verbatim: "PR and GitHub-issue titles & descriptions must be bilingual — include a Simplified Chinese version in addition to English. ... In the PR/issue body, follow the English content with its Chinese translation (e.g. a ## 中文说明 section mirroring the summary...). This applies to every PR and every issue."
PR #2447's title correctly follows the <English> / <中文> format ("...EAGLE MTP and golden-AL synthetic acceptance / 新增 GLM-5.2 NVFP4 B300 SGLang EAGLE MTP AgentX 配置(黄金 AL 合成接受率)"). However, the description body — the intro paragraph plus the "What's here", "MTP", "Synthetic acceptance length", "Image bump", "Search space", and "Validation" sections — is entirely English. There is no mirrored ## 中文说明 section, nor any trailing Chinese paragraph summarizing the content, anywhere in the body.
This satisfies only half of the explicit, repo-wide bilingual mandate (title done, body not done). The rule is unambiguous and not a matter of subjective style — CLAUDE.md defers entirely to AGENTS.md, and AGENTS.md states this applies to "every PR and every issue," with no carve-out for recipe/config PRs. Nothing in existing tooling enforces this automatically (there's no bot check for body-level bilingual content, only the CODEOWNER sign-off phrase bot), so it falls on human/AI review to catch it.
Proof by inspection: scanning the full PR description body for any Chinese characters or a 中文 heading turns up none outside the title — every section header and every line of prose is ASCII English. Contrast this with recent merged commits in this same repo that do carry bilingual PR titles and (per the AGENTS.md convention) bodies, confirming the convention is actively expected and enforced elsewhere in the project.
Impact and fix: this is purely a documentation/process gap — it does not touch the benchmark script, the master-config entry, the golden AL YAML, or any runtime behavior, so nothing breaks if this merges as-is. The fix is simply for the author to append a ## 中文说明 section (or trailing 中文 paragraph) that mirrors the English summary, following the terminology and idiomatic-translation guidance also laid out in AGENTS.md (e.g. keeping SKU/framework/flag names in English).
Severity is nit: it's a real, verifiable violation of an explicit repo rule, but it affects only the PR description prose, not the code or config under review, and is trivially fixed by editing the description text.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30729399405 |
…P and golden-AL simulated acceptance
Adds the spec-decode arm of the GLM-5.2 NVFP4 B300 agentic-coding recipe, the
arm that replaces the STP entry once agentic non-MTP is deprecated for GLM-5.2
on 2026-08-03 (MODELS.md).
- benchmarks/single_node/agentic/glm5.2_fp4_b300_sglang_mtp.sh: the validated
STP script plus SGLang EAGLE off GLM-5.2's built-in nextn head (num-steps 3,
eagle-topk 1, 4 draft tokens) and SGLANG_SIMULATE_ACC_* pinned to the golden
AL, left off under EVAL_ONLY so accuracy runs keep real verification.
- golden_al_distribution/glm5.2_mtp.yaml: the GLM-5.2 MTP curve verbatim from
the speedbench-al.yml artifact of run 28058352479, plus the README rows.
- configs/nvidia-master.yaml: TP8 + HiCache at conc [1, 4, 8, 12, 16] on
lmsysorg/sglang:v0.5.16-cu130, the first release that reads
SGLANG_SIMULATE_ACC_TOKEN_MODE.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fcfd122 to
a3c7a4c
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30731367329 |
Adds
glm5.2-fp4-b300-sglang-agentic-mtp— the speculative-decoding arm of the GLM-5.2 NVFP4 B300 AgentX recipe, and the arm that replaces the existing STP entry once agentic non-MTP is deprecated for GLM-5.2 on 2026-08-03 (MODELS.md). The STP entry is left untouched so the two can be compared before the cut-over.What's here
benchmarks/single_node/agentic/glm5.2_fp4_b300_sglang_mtp.shgolden_al_distribution/glm5.2_mtp.yamlgolden_al_distribution/README.md,README_zh.mdconfigs/nvidia-master.yamlperf-changelog.yamlMTP
GLM-5.2 ships its own nextn head, so SGLang EAGLE runs off the checkpoint with no external draft model:
3 speculative tokens per verification step — the same shape the GLM-5.2 GB300 dynamo-sglang agentic recipes use.
Synthetic acceptance length
Throughput runs pin acceptance to the committed golden AL, per the AgentX policy in
golden_al_distribution/README.md:EVAL_ONLYruns leave it off — simulated acceptance commits drafted tokens regardless of the target logits, so the eval would score ~0.GLM-5.2 had no committed golden curve, so this PR commits one.
golden_al_distribution/glm5.2_mtp.yamlis verbatim from thespeedbench-al.ymlartifact of run 28058352479 (SPEED-Benchcoding, output-len 4096, temperature 1.0, top_p 0.95, thinking_on,num_speculative_tokens1–8); K=3 is 2.99. Reviewers: this is the one item here that needs the golden-curve review checklist, not just a recipe read. Note the collection ran on the FP8 checkpoint — one curve is committed per model and the NVFP4 checkpoint ships the same nextn head.Image bump
lmsysorg/sglang:v0.5.15.post1-cu130→lmsysorg/sglang:v0.5.16-cu130(verified on Docker Hub, pushed 2026-07-24).SGLANG_SIMULATE_ACC_TOKEN_MODEis only read from v0.5.16 —SIMULATE_ACC_LEN/SIMULATE_ACC_METHODexist further back, so an older image would silently ignore the token-mode half of the contract. v0.5.16-cu130 is also the tag the GLM-5.2 GB300 dynamo-sglang agentic recipes already run.Search space
One arm on the AgentX MTP concurrency grid:
- { tp: 8, spec-decoding: mtp, kv-offloading: dram, kv-offload-backend: { name: hicache }, conc-list: [1, 4, 8, 12, 16] }--speculative-moe-a2a-backend none/--speculative-moe-runner-backend tritonpair that GLM-5.2-NVFP4's unquantized bf16 nextn layer (hf_quant_configexcludesmodel.layers.78*) needs once expert parallelism puts an all-to-all in the MoE path — so the throughput arm can be added later without re-deriving it.mem-fraction-staticstays at 0.85, which is what both the B300 STP script and the GLM-5.2 GB300 aggregated MTP recipe use;hicache-ratiois relative to the device pool, so the nextn layer's own KV only shrinks the host pool.Validation
bash -nclean;perf-changelog.yaml/configs/nvidia-master.yamlparse; diff is additions only.generate_sweep_configs.py test-configandprocess_changelog.pyagainstorigin/mainboth select exactly the 5 expected jobs (glm5.2_tp8_conc{1,4,8,12,16}_kvdram-hicache_spec-mtp).benchmarks/single_node/agentic/glm5.2_fp4_b300_sglang_mtp.sh.Sweep results to follow.