[Klaud Cold] kimik2.6-fp4-b200-dynamo-vllm: remove no-enable-flashinfer-autotune, target b200-new / 移除 no-enable-flashinfer-autotune - #2445
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
1 similar comment
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30699011741 |
| model: nvidia/Kimi-K2.6-NVFP4 | ||
| model-prefix: kimik2.6 | ||
| runner: b200-multinode | ||
| runner: b200-new |
There was a problem hiding this comment.
🔴 This PR retargets kimik2.6-fp4-b200-dynamo-vllm from runner: b200-multinode to runner: b200-new, but no such runner label exists anywhere in the repo — configs/runners.yaml only defines b200, b200-dsv4, and b200-multinode for Blackwell. Since this label is passed verbatim into the GitHub Actions runs-on, the multi-node job will queue indefinitely with no matching self-hosted runner instead of failing fast, which defeats the full-sweep-fail-fast validation this PR is labeled with.
Extended reasoning...
The core functional change in this PR is configs/nvidia-master.yaml:4984, which changes runner: b200-multinode to runner: b200-new for the kimik2.6-fp4-b200-dynamo-vllm entry. I grepped the entire repository and b200-new appears in exactly two places: this new master-config line and the corresponding perf-changelog.yaml:5362 entry describing the change. It is not defined anywhere else.
configs/runners.yaml is the source of truth for valid runner labels. Its labels: map defines only b200, b200-dsv4, and b200-multinode for B200 hardware (lines 53–82) — there is no b200-new key, and there is no corresponding hardware: entry or runners/launch_b200-new*.sh launcher script either. Per AGENTS.md's "Adding a runner" section, introducing a new runner requires three things: (1) an entry in configs/runners.yaml, (2) a launcher script under runners/, and (3) the master-config reference. This PR only does step (3).
I traced how this value is consumed. generate_sweep_configs.py only validates runner labels against runner_labels() when the CLI's --runner-type filter is explicitly passed (lines ~421-427) — it never validates the config's own runner: field during normal generation. For the multi-node fixed-seq-len path, the runner value is read unvalidated and emitted directly as the entry's runner list (runners_for_entry = [runner] when no node filter is set). That value then flows into .github/workflows/benchmark-multinode-tmpl.yml, which builds runs-on: ["self-hosted", inputs.runner, ...] verbatim. Since no self-hosted runner pool is registered with the b200-new label, the resulting GitHub Actions job has no runner to match against.
The practical impact: instead of failing fast (which the full-sweep-fail-fast label on this PR is meant to guarantee), the multi-node job for kimik2.6-fp4-b200-dynamo-vllm will simply queue forever with no runner available to pick it up. This is worse than an explicit failure — it silently hangs, consuming a queued job slot and giving no clear signal to the PR author about what went wrong, unlike a validation error that would point directly at the missing runner registration.
Concrete walkthrough:
configs/nvidia-master.yaml:4984now readsrunner: b200-newforkimik2.6-fp4-b200-dynamo-vllm.generate_sweep_configs.pygenerates the multi-node sweep entry for this config, copyingrunner: b200-newthrough unchanged (no validation trips).- The GitHub Actions workflow for this entry sets
runs-on: ["self-hosted", "b200-new", ...]. - GitHub Actions looks for a registered self-hosted runner advertising the
b200-newlabel. None exists (configs/runners.yamlonly advertisesb200,b200-dsv4,b200-multinode), so the job sits in "Queued" indefinitely. - Even if a runner pool were manually tagged
b200-newoutside ofconfigs/runners.yamlto work around this, the multi-node SLURM launch would still needrunners/launch_b200-new*.sh, which doesn't exist.
To fix this, the author should either revert to runner: b200-multinode (if the intent was just to remove no-enable-flashinfer-autotune, which is the PR's stated purpose) or, if b200-new is an intentional new runner pool, complete the registration by adding it to configs/runners.yaml with its node list and adding the launcher script per AGENTS.md's "Adding a runner" instructions.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30699385227 |
|
looking |
|
closed in favor of #2438 |

Summary
Remove
no-enable-flashinfer-autotune: truefrom all 7disagg-b200-*recipe YAMLs underbenchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k2.6/b200-fp4/8k1k/.中文说明
从
benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k2.6/b200-fp4/8k1k/下所有 7 个disagg-b200-*配方 YAML 中移除no-enable-flashinfer-autotune: true。