fix: catch KeyboardInterrupt during startup cleanup - #8
Open
Alicepoltora wants to merge 1 commit into
Open
Alicepoltora wants to merge 1 commit into
Alicepoltora wants to merge 1 commit into
Conversation
start_node() unwinds recorded start requests after an ordinary startup error (SupervisorError), but skipped that cleanup on KeyboardInterrupt. This left programs started by the interrupted command running after the CLI reported an interruption. Changed except Exception to except BaseException so that KeyboardInterrupt also triggers the reverse cleanup of already-started programs before re-raising. Fixes SeismicSystems#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7
Problem
start_node()recorded ownership throughon_start_requestedand unwound those starts onSupervisorError. Butexcept Exception:does not catchKeyboardInterrupt, so Ctrl+C during startup left already-started programs running.Fix
Changed
except Exception:toexcept BaseException:so thatKeyboardInterruptalso triggers the reverse cleanup of already-started programs before re-raising.Behavior
KeyboardInterruptis re-raised to preserve exit code 130