Skip to content

fix(android): clip a list to its bounds - #21

Merged
SectionTN merged 1 commit into
mainfrom
fix/android-list-clip
Nov 22, 2026
Merged

SectionTN merged 1 commit into
mainfrom
fix/android-list-clip

Conversation

@SectionTN

@SectionTN SectionTN commented Nov 22, 2026 •

Copy link
Copy Markdown
Owner

on Android a pinned sticky row pushed by the next header moved past the list's top edge and drew over the views above the list, about 22 dp of it on the example's React tab. both pinned copies are children of the list view moved with a translation, and React Native parents don't clip their children. the list now clips its drawing to its bounds, as a ScrollView does on Android and the collection view does on iOS.

a pushed sticky row over the chips above the list, then clipped at the list edge

Summary by CodeRabbit

  • Bug Fixes
    • View content is now clipped to the view's visible bounds, preventing drawing from extending beyond its edges.
    • This keeps rendered content contained within its display area while preserving the existing view hierarchy and behavior.

… with it

A pinned sticky row pushed by the next header moved past the list's top edge and drew over
the views above the list, about 22 dp of it on the example's React tab. Both pinned copies are
children of the list view moved by a translation, and React Native parents do not clip their
children. The list now clips its drawing to its bounds, as a ScrollView does on Android and the
collection view does on iOS.
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

FlumeView now clips drawing of its view hierarchy to the view’s bounds.

Changes: View Drawing

Layer / File(s) Summary
Clip view drawing
android/src/main/java/me/sectiontn/flume/FlumeView.kt
FlumeView overrides dispatchDraw to clip the canvas to the view’s bounds, draw the view hierarchy, and restore the canvas state. It imports Canvas for the override.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: Minimal · up to a46bf

This change clips the Android list to its bounds so a pushed sticky row no longer draws above the list. No concrete risk was found, and the change is low-risk to merge.

Security architecture risk: Minimal · up to a46bf

The change confines Android list drawing to the list’s bounds. No introduced or worsened risk affecting security, failure containment, rollback, or ownership was established.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(android): clip a list to its bounds" matches the main change. The raw summary shows FlumeView.kt adds a dispatchDraw override that saves the canvas, clips drawing to the view's bounds, …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "fix(android): clip a list to its bounds" matches the main change. The raw summary shows FlumeView.kt adds a dispatchDraw override that saves the canvas, clips drawing to the view's bounds, draws the hierarchy, and restores the canvas. The objectives say the change stops a pinned sticky row from drawing above the list on Android. The title names the Android platform, the clipping behavior, and the list. It does not name the sticky row bug, but it covers the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bfdf3662-fffe-408b-bdc9-06a8c3b343b5
Commits

Reviewing files that changed from the base of the PR and between a073a33 and a46bf35.

Files selected for processing: 1

  • android/src/main/java/me/sectiontn/flume/FlumeView.kt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@SectionTN
SectionTN merged commit 2e596b1 into main Nov 22, 2026
5 checks passed
@SectionTN
SectionTN deleted the fix/android-list-clip branch November 22, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant