Repository navigation
fix(android): clip a list to its bounds - #21
Merged
Merged
Conversation
… with it A pinned sticky row pushed by the next header moved past the list's top edge and drew over the views above the list, about 22 dp of it on the example's React tab. Both pinned copies are children of the list view moved by a translation, and React Native parents do not clip their children. The list now clips its drawing to its bounds, as a ScrollView does on Android and the collection view does on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on Android a pinned sticky row pushed by the next header moved past the list's top edge and drew over the views above the list, about 22 dp of it on the example's React tab. both pinned copies are children of the list view moved with a translation, and React Native parents don't clip their children. the list now clips its drawing to its bounds, as a ScrollView does on Android and the collection view does on iOS.
Summary by CodeRabbit