Skip to content

ci: build the iOS example and run the jsi suite on macOS - #18

Merged
SectionTN merged 1 commit into
mainfrom
ci/ios-job
Nov 20, 2026
Merged

SectionTN merged 1 commit into
mainfrom
ci/ios-job

Conversation

@SectionTN

@SectionTN SectionTN commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

the jsi suite links React Native's macOS Hermes framework, so the cpp job on Linux skipped it and CI never ran the bindings under ASan. the repo is public now so macOS runners are free, the new ios job on macos-26 runs the whole C++ suite, then prebuilds the example, installs pods and builds a Debug simulator app with the runner's default Xcode (26.6).

Summary by CodeRabbit

  • Tests
    • Automated checks now run the C++ core and JSI test suites on iOS, prebuild the iOS example, and build the Debug iOS Simulator target. This adds coverage for iOS-specific builds and test results.

The jsi suite links React Native's macOS Hermes framework, so the Linux
cpp job skipped it and CI never ran the bindings under ASan. The new job
runs the whole C++ suite on macOS, then prebuilds the example and builds
it for the simulator with the runner's default Xcode.
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow adds an iOS job on macos-26. It runs the C++ test suite, prebuilds the iOS example, installs pods, and builds the Debug iOS Simulator target for arm64 with code signing disabled.

Changes: iOS CI

Layer / File(s) Summary
iOS test and build job
.github/workflows/ci.yml
The workflow comment says the JSI suite runs in the iOS job. The new job runs yarn test:cpp, prebuilds the iOS example, installs pods, and builds the Debug iOS Simulator target for arm64 with code signing disabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to c52ec

This change adds an iOS CI job and affects no runtime behavior. The only remaining unknown is whether the new job passes on its first run, and it can be resolved by running CI.

Security architecture risk: Minimal · up to c52ec

The new job builds and tests an unsigned simulator application without adding publishing, deployment, signing, or explicitly provisioned secret access. No introduced or worsened material security risk was established.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — PR-controlled code and build dependencies gain a macOS execution environment, including native compilation and dependency installation. The directly evidenced exposure is the CI runner workspace and its dependency-cache interaction, not a signing identity, production service, or customer data store.

Trust Boundaries and Controls

  • observed — The workflow uses pull_request rather than pull_request_target for PR validation. The shared setup restores executable dependency content from an OS-prefixed cache, runs an immutable install on a cache miss, and saves dependencies under the primary cache key. Repository inspection establishes this mechanism but does not independently establish the hosting platform's cross-ref cache isolation.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: build the iOS example and run the jsi suite on macOS" matches the main change. The raw summary says the new ios job on macos-26 runs the C++ core and JSI tests, prebuilds the iOS exampl…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: build the iOS example and run the jsi suite on macOS" matches the main change. The raw summary says the new ios job on macos-26 runs the C++ core and JSI tests, prebuilds the iOS example, installs pods, and builds the Debug iOS Simulator target. The PR objectives say the JSI suite moves to macOS so it runs under ASan. The title names the two main parts of the change and uses a conventional commit prefix. It does not mention the Pods install or the arm64 simulator build, which is expected for a short title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b5d3f611-fdd1-4772-846e-7f88c917454f
Commits

Reviewing files that changed from the base of the PR and between 3def2d1 and c52ec3c.

Files selected for processing: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@SectionTN
SectionTN merged commit 50d3d55 into main Nov 20, 2026
5 checks passed
@SectionTN
SectionTN deleted the ci/ios-job branch November 20, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant