Repository navigation
Hold TypeScript at 6.x so lint keeps working - #15
Closed
vpetersson-bot wants to merge 1 commit into
Closed
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
typescript-eslint declares a peer range of typescript >=4.8.4 <6.1.0. TypeScript 7 removed ts.Extension.Cjs, so @typescript-eslint/typescript-estree throws on load and bun run lint fails outright. Take the rest of the dependency bump, keep typescript on the existing range, and tell dependabot to skip TypeScript 7 until typescript-eslint supports it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The constraints still permit TypeScript 6.1+, outside the documented supported range.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Refreshes development dependencies while constraining TypeScript to preserve lint compatibility.
Changes:
- Updates development dependencies and lockfile.
- Adds a Dependabot TypeScript exclusion.
- Retains TypeScript 6.0.3.
| File | Description |
|---|---|
package.json |
Updates development dependency ranges. |
bun.lock |
Records resolved dependency updates. |
.github/dependabot.yml |
Excludes incompatible TypeScript updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # "TypeError: undefined is not an object (evaluating 'ts.Extension.Cjs')". | ||
| # Remove this once typescript-eslint supports TypeScript 7. | ||
| - dependency-name: 'typescript' | ||
| versions: ['>=7'] |
| "jsdom": "^30.0.1", | ||
| "npm-run-all2": "^9.0.3", | ||
| "prettier": "^3.9.6", | ||
| "typescript": "^6.0.3" |
Author
|
Closing this as a duplicate — an equivalent change (same TypeScript holdback plus the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bun run lintdies on the monthly dependency bump with:typescript-eslint(pulled in via@screenly/edge-apps) declares a peer range oftypescript >=4.8.4 <6.1.0, and its latest release still does. TypeScript 7 removedts.Extension.Cjs, so@typescript-eslint/typescript-estreethrows while loading,before a single file is parsed. Nothing in this repo can work around that.
This takes the rest of the bump but leaves
typescripton^6.0.3, and adds adependabot
ignoreentry so TypeScript 7 is not proposed again untiltypescript-eslintsupports it. Drop theignoreentry at that point.Verified locally:
bun run lint,bun run type-check,bun run buildandbun test src/all pass.🤖 Generated with Claude Code