Add marker location editing back in - #1122
Merged
Merged
Conversation
AndroidOfflineMapsManager wrote an extract's metadata sidecar before the download started, under a new timestamped name each time, and a download that failed or was cancelled only cleaned up its .downloading file. The sidecars stayed on the phone forever with no extract next to them - one test phone had six (two for Helsinki) and no extracts at all. The downloader now writes the sidecar itself, only once the extract is published, as the shared OfflineMapManager already does. Sidecars left by earlier versions are deleted when the downloaded list is refreshed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THRgoVbh1G3pVacd7csDqJ
They're off Craigmillar Avenue near the James Gale Memorial, about 1km from Milngavie station - not by the station, as the comment (and the commit message of fff466c) wrongly said. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THRgoVbh1G3pVacd7csDqJ
Moving a marker by panning the full-screen map was lost in the move to the shared screen: MapContainerLibre's editBeaconLocation flag was no longer passed through PlatformMapContainer, and the screen always saved the original location. The map now takes an onBeaconLocationEdited callback which pins the marker to the camera centre and reports each new position, instead of mutating the caller's LngLatAlt during composition. Editing the location is a distinct mode with its own title, instructions and Cancel/Done (and system back cancels); the FAB and Delete Marker button are hidden while in it, and the FAB uses an edit-location icon. The now unused location_detail_exit_full_screen_for_edit_hint string is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THRgoVbh1G3pVacd7csDqJ
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.