Provide density profile coefficients from grid index - #313
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 79 79
Lines 8629 8639 +10
=======================================
+ Hits 8413 8423 +10
Misses 216 216 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
After this PR I would probably recommend to remove the level local alpha and beta cache vectors if the call alpha(i,j) doesnt do any computations and only retrieves from a vector. Memory consumption in 64-bit vector equivalents on level 0: I can create a corresponding PR if that is something we want to do. |
Currently in my tests GMGPolar is slower than our other solver which is unexpected so if you have any ideas to speed things up this could be good. Currently my main hypothesis is that the difference comes from the fact that the other solver allows us to provide an initial guess to reduce the number of iterations whereas GMGPolar doesn't allow this |
|
@EmilyBourne Can you show me the output when using verbose=1 and ? |
Provide density profile coefficients from grid index instead of expecting an analytical expression.
This input seems to have been forgotten when we did this work for other inputs. Without this change Gyselalib++ needs to interpolate the coefficients in order to provide the values at any point in space.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):