Conversation
A EUR invoice kept its currency on the document, but posting copied the same number into the single-currency ledger and the UI labeled it CHF. Convert at the exchange rate on or before the document date, and refuse to post when no rate exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Community Edition invoice form accepts EUR (and other currencies), and the preview formats that currency correctly. Posting then copies the same number into the ledger, which has no currency of its own, and every journal screen formats amounts as CHF. A 100.00 EUR invoice is booked as 100.00 CHF, not as the franc equivalent.
This is reusable accounting behavior, so it belongs in the public edition.
FEATURE_MULTI_CURRENCYonly hid the exchange-rate screen; it did not stop a foreign-currency invoice from being issued.Payments use the invoice-date rate so the receivable clears. A later payment-date exchange difference is not posted.
Test plan
test_eur_invoice_is_booked_in_the_organization_currency— 1,621.50 EUR at 0.95 posts 1,540.43 CHFtest_foreign_invoice_without_an_exchange_rate_is_not_posted