Repository navigation
Fix server-rendered maintenance page design - #112
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The production request middleware in
src/start.tsintercepts HTML requests while maintenance mode is enabled and returnsrenderMaintenancePage()fromsrc/lib/error-page.ts. This server-rendered HTML bypasses the redesigned ReactMaintenanceGate, which is why production kept showing the old page even though the React component had been updated and deployed.Fix
Scope
Only
src/lib/error-page.tsis changed. No Supabase settings, environment variables, domain assignments, or deployment settings are modified.Validation
Source reviewed against the live production middleware path. A Vercel build and browser verification are still required after merge.