Repository navigation
fix(telegram): restore user Links and send connection URL with QR - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users → user → Link currently returns “This menu is out of date — send /menu” even from a freshly opened menu. The button emits
u:k:<label>, butTG_CB_CAPShas nou:kentry, so the dispatcher rejects it before sending anything. Addingu:k=adminwas verified on a live server and restored QR delivery.This PR also includes the complete connection URL behind a compact 🔗 Connect link in the QR caption, so administrators can tap or copy the link directly from the same message. FakeTLS keeps its full
eesecret and domain suffix. Only the compact link caption opts into Markdown; the server label is escaped, and other photo captions retain their plain-text behavior.Photo delivery now checks the Bot API
okresult instead of treating every successful curl exit as delivery. If QR generation or upload fails, the bot tries a plain connection link; if that also fails, the callback shows an error rather than claiming success.Validation: 201 checks passed across the callback dispatcher, QR/limits, and per-secret management suites, plus Bash syntax and git diff checks. The new tests exercise
u:k:alicethrough the actual authorization dispatcher, confirm unauthorized callers receive no link, verify the full URL in a successful photo caption, and cover rejected photo/text API responses. Tests ran in Cygwin with LF-normalized copies; the QR/limits suite required an environment-onlyxargs -s 4096wrapper for the local Cygwin command-size limit. Live-server confirmation of the combined QR caption is pending.