Fix Snell v6 shaped buffer headroom fallback - #5
Open
kitdine wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the allocating fallback for Snell v6 shaped records when an input
buffer does not provide enough front headroom or AEAD-tag tailroom.
The in-place fast path is unchanged when the supplied buffer has sufficient
space.
Root cause
f4a50434aa5eremoved the fallback fromshapedWriter.makeBufferRecord. A routed UDP packet can legitimately arrivewith less headroom than the current shaping sequence requires. Calling
ExtendHeaderin that case panics instead of writing an allocated record.Observed with sing-box
v1.14.0-alpha.50and Snell v6:Changes
makeSliceRecordwhen front or rear space is insufficient;possible return values;
sufficient-space fast path.
Verification
All completed successfully on Go 1.26.5.
The patched dependency was also built into sing-box for Linux/amd64 and tested
with a greater-than-1-KiB UDP packet across:
The packet completed and the intermediate sing-box process remained running.
Refs #4.
This PR intentionally limits its scope to the reproduced Snell v6 shaped
packet failure. The original issue also reports a Snell v4 nested-vectorised
writer failure, which follows a different call path and is not closed by this
change.