Repository navigation
[SYNPY-1930] Deprecate schema registry functions - #1467
Merged
Merged
Conversation
thomasyu888
reviewed
Oct 12, 2026
thomasyu888
left a comment
Member
There was a problem hiding this comment.
We should still make sure the function works even if it's plan is to be deprecated: https://sagebionetworks.slack.com/archives/C02M7QR8D46/p1791230490708289?thread_ts=1791225742.847109&cid=C02M7QR8D46
Perhaps it's a python 3.14 thing for our users but it would be good to diagnose.
Contributor
Author
|
@thomasyu888 There's a separate issue for doing the actual fix: https://sagebionetworks.jira.com/browse/SYNPY-1931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
synapseclient/extensions/curator/schema_registry.pyfind JSON schema URIs by a SQL query on a schema registry table (syn69735275). The public functions are:query_schema_registryget_latest_schema_uriOrganizationandJSONSchemamodels insynapseclient.modelsnow let users find JSON schemas and their versions directly through the Synapse JSON schema API. Users do not need to keep a separate registry table up to date.Solution:
@deprecateddecorator (from thedeprecatedpackage, as inmodels/organization.py) toquery_schema_registryandget_latest_schema_uri:version="4.15.0"OrganizationandJSONSchema, and has an example that usesOrganization.get_json_schemas()andJSONSchema.get_versions().DeprecationWarning.SchemaRegistryColumnConfigis not deprecated, because it is a dataclass, not a function. It is used only by the deprecated functions.get_latest_schema_uricallsquery_schema_registry, so one call shows two deprecation warnings.docs/guides/extensions/curator/metadata_curation.mdandsynapseclient/extensions/curator/readme.mdstill showquery_schema_registry. We can update them in a different PR.