Skip to content

Issues with CoolingHalo examples #10

Description

@mmlinford

Hello,

There seem to be a few issues with the CoolingHalo and CoolingHaloWithSpin examples:

  • A script radial_profile.py is in run.sh, but there is none in the project
  • I had to decrease dt_min to 1e-8 or it complained about parts wanting time-steps below the dt_min
  • internal_energy_profile.py refers to unrelated Hydrostatic_####.hdf5 files
  • test_energy_conservation.py refers to SoftenedIsothermalPotential:vrot, which doesn't exist anymore since softened isothermal potential was removed
  • parameters passed to the python scripts from run.sh don't make sense. The python scripts seem to expect different numbers of parameters than what the run.sh scripts pass in. One of them doesn't parse correctly ("2." can't be parsed as an int)

So it isn't really possible to run those examples as they are right now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions