Skip to content

Sync: fix the macOS build after #325 (floating-point from_chars) #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProgenyAlpha wants to merge 1 commit into from
Closed

Sync: fix the macOS build after #325 (floating-point from_chars) #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mods/src/patches/parts/sync.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
#include <algorithm>
#include <atomic>
#include <charconv>
#include <locale>
#include <sstream>
#include <chrono>
#include <cmath>
#include <condition_variable>
Expand Down Expand Up @@ -2480,10 +2482,15 @@ namespace deployed_fleets
return static_cast<int64_t>(value);
}

// Floating-point std::from_chars needs macOS 26's libc++; a classic-locale stream reads the same text everywhere.
char buffer[32];
double widened = value;
if (const auto [end, ec] = std::to_chars(std::begin(buffer), std::end(buffer), value); ec == std::errc{}) {
std::from_chars(std::begin(buffer), end, widened);
std::istringstream in(std::string(std::begin(buffer), end));
in.imbue(std::locale::classic());
if (double parsed; in >> parsed) {
widened = parsed;
}
}
return widened;
}
Expand Down
Loading