Repository navigation
Fix/568 existing validators - #571
Merged
Merged
Conversation
Fixes values the plugin flagged although systemd accepts them, and values it
accepted although systemd rejects them, for ExecStart= and the other command
keys, WorkingDirectory=, EnvironmentFile=, Standard{Input,Output,Error}=,
IOSchedulingClass=, IO*Max= limits, Memory*= limits, CPUAffinity=,
CapabilityBoundingSet=/AmbientCapabilities=, SystemCallErrorNumber=, Nice=,
LimitNICE= and other rlimits, signals, ReadOnlyPaths= and friends, and
RootImagePolicy= and friends. Unknown %-specifiers are now refused and %% is
treated as a literal %.
Part of #568. Verdicts were checked against systemd's own parsers built at
the pinned commit 0f0682b773 (condition values against src/shared/condition.c,
since systemd only evaluates them at unit start). Values systemd accepts at
parse time but rejects only later are accepted (see #565).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…#568) Fixes dependency keys (OnFailure=, Wants=, After=, ...) with specifiers, FailureAction=/SuccessAction=/JobTimeoutAction= values such as halt-force, trigger units, timeouts and cgroup settings, so they match what systemd accepts. Part of #568. Verdicts were checked against systemd's own parsers built at the pinned commit 0f0682b773 (condition values against src/shared/condition.c, since systemd only evaluates them at unit start). Values systemd accepts at parse time but rejects only later are accepted (see #565). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
#568) Fixes ERSPANHardwareId= and other integer settings that rejected hex or signed spellings systemd accepts, FooOverUDP Protocol=, Xfrm InterfaceId=, DHCP SocketPriority= bounds and related network-file settings. Part of #568. Verdicts were checked against systemd's own parsers built at the pinned commit 0f0682b773 (condition values against src/shared/condition.c, since systemd only evaluates them at unit start). Values systemd accepts at parse time but rejects only later are accepted (see #565). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…cks (#568) Re-checked every flagged condition value against systemd's runtime condition code, fixed the values that can work, and pinned the ones that can never work (for example ConditionVirtualization= with several words) with tests. Part of #568. Verdicts were checked against systemd's own parsers built at the pinned commit 0f0682b773 (condition values against src/shared/condition.c, since systemd only evaluates them at unit start). Values systemd accepts at parse time but rejects only later are accepted (see #565). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Unit Test Results (grammar engine true)1 899 tests 1 899 ✅ 1m 8s ⏱️ Results for commit 2c66c5d. |
Unit Test Results (grammar engine false)1 899 tests 1 899 ✅ 1m 26s ⏱️ Results for commit 2c66c5d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.