Repository navigation
Conversation
Unit Test Results (grammar engine false)1 380 tests 1 380 ✅ 50s ⏱️ Results for commit 8474666. ♻️ This comment has been updated with latest results. |
Unit Test Results (grammar engine true)1 380 tests 1 380 ✅ 1m 8s ⏱️ Results for commit 8474666. ♻️ This comment has been updated with latest results. |
sjrx-claude-sandbox
force-pushed
the
feat/validators-exec
branch
3 times, most recently
from
October 24, 2026 17:11
f87e368 to
88b637f
Compare
…nd environment options (exec batch) Adds C-sourced grammars (pinned to systemd 0f0682b773) for BindPaths=/BindReadOnlyPaths=, TemporaryFileSystem=, RootImageOptions=, MountImages=, ExtensionImages=, NUMAMask=, ImportCredential=, RootHash=, RootHashSignature=, StandardInputData=, CoredumpFilter=, Environment=, the [Slice] concurrency limits and LUOSession=, with shared helpers in grammar/BatchExecCombinators.kt. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- safeAtouNumber: only allow '+' before the plain strtoul branch, so +0b1/+0o7 are rejected as mangle_base does; optionally accept a negative zero (-0, -0x0), used by the [Slice] concurrency limits. - CoredumpFilter=: accept a negative zero, which safe_atollu_full allows. - C escapes: refuse UTF-16 surrogates in \u and invalid code points in \U, matching cunescape_one/unichar_is_valid. - RETAIN_ESCAPE tuple fields: a backslash before a quote is not an escape; the quote must open a balanced quoted run. - Correct the header note: opaque quoted runs can also flag some valid values. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Several batch branches declared public helpers with the same name in the shared grammar package (SafeAtouTerminal, UINT32_LIMIT, safeAtou, SafeAtoNumberTerminal, BOOLEAN_ANY_CASE, COALESCED_COLONS). Each branch compiled alone but any two merged together would not. Prefix them per family so the batch PRs can merge in any order; consolidating them into Combinators.kt is left for a follow-up. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Replace the exec batch's local safe_atou copy (safeAtouNumber, PLUS_SIGN, NEGATIVE_ZERO and the hand-written 0b/0o range regexes) with the shared SafeAtoTerminal in ConcurrencyHardMax=/ConcurrencySoftMax=/ ActivatingConcurrencyMax= and NUMAMask=. Verdicts now match systemd (checked with sd-check at 0f0682b773): - Concurrency*Max= now accepts 0b+1, 0b-0, "0b 1", "0o 7", "0b +1", "0b -0" and a leading \v. - NUMAMask= now accepts 0b+1, 0-0b+1 and 0--0 (parse_range's upper bound may be a negative zero); -0, 0b-0 and 1-2-3 stay flagged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sjrx-claude-sandbox
force-pushed
the
feat/validators-exec
branch
from
October 24, 2026 18:30
88b637f to
8474666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.