Skip to content

Remove unused owned variable and stale comment in FieldSerializer::Serialize #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Remove unused owned variable and stale comment in FieldSerializer::Serialize #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b94b101
Initial plan
Copilot Aug 20, 2026
5bc8cf5
Remove unused owned variable in FieldSerializer Serialize
Copilot Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/pcms/coupler/field_serializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ class FieldSerializer
Rank1View<const LO, HostMemorySpace> permutation) const
{
auto data = field.GetDOFHolderDataHost();
auto owned = layout.GetOwnedHost();
// The exchange plan is per DOF holder: owned[i] and permutation[i] are
// indexed by holder. All num_components components of a holder share its
// The exchange plan is per DOF holder: permutation[i] is indexed by holder.
// All num_components components of a holder share its
// location, so they occupy one contiguous block permutation[i]*num_comp in
// the wire buffer.
if (buffer.size() > 0) {
Expand Down