Temporarily disabling DNN ROI to enable CI tests in short term#916
Temporarily disabling DNN ROI to enable CI tests in short term#916SFBayLaser wants to merge 1 commit into
Conversation
|
I am not sure why this is referencing the develop branch as I had explicitly checked out v10_20_09p02... I will try to change the base. nvmnd... can't base to a tag... |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
cerati
left a comment
There was a problem hiding this comment.
Approving, assuming this is a temporary (<1 month) patch. If this becomes more permanent, then I'd prefer the changes go into standard_mc_all_stage0_icarus.fcl and standard_data_all_stage0_icarus.fcl.
This PR is meant to temporarily disable the DNN ROI finding in both data and MC. At issue is that the latest versions of the Wirecell toolkit, including the version that gives us the updated yz simulation, are crashing in the DNN ROI finding and this is preventing us from debugging the rest of the CI test system. We don't know when we will see an updated wirecell toolkit so hopefully "unsticking" the problem with this temporary update.