[FIX] generateFlexBundle: Improve flexBundle flagging - #1233
Merged
Merged
Conversation
d3xter666
previously requested changes
Aug 31, 2026
Lonwyr
force-pushed
the
fixFlexBundle
branch
from
September 7, 2026 10:43
5d96022 to
aac04c6
Compare
Lonwyr
commented
Sep 7, 2026
Lonwyr
left a comment
Lonwyr
left a comment
Contributor
Author
There was a problem hiding this comment.
adjusted the property, the JSDoc and all mentioned references. I kept the original comment open in case you have feedback on the current naming proposal
Lonwyr
force-pushed
the
fixFlexBundle
branch
from
September 7, 2026 10:55
aac04c6 to
689cdcc
Compare
Lonwyr
force-pushed
the
fixFlexBundle
branch
from
September 10, 2026 11:08
689cdcc to
5c58ba2
Compare
* the flag should only be used for the flexibilityBundle * to improve the client performance, it now also only sets the flag in case of a mandatory early loading of the bundle. Otherwise, the file can be loaded from the -preload
Lonwyr
force-pushed
the
fixFlexBundle
branch
from
September 10, 2026 12:59
5c58ba2 to
6967603
Compare
matz3
changed the title
matz3
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist