Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 88.38% 85.42% -2.97%
==========================================
Files 81 77 -4
Lines 3961 3684 -277
==========================================
- Hits 3501 3147 -354
- Misses 460 537 +77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
p-j-smith
left a comment
p-j-smith
left a comment
There was a problem hiding this comment.
very cool, just a question around whether we should remove the existing lgtm service from the system tests, and how to set up the external stack locally
| the `telemetry` repo's `otel-agent/` directory, set | ||
| `PIXL_NETWORK=system-test_pixl-net` and run: | ||
| ```bash | ||
| docker compose -f docker-compose.yml -f host_overrides/compose.gae14.override.yml up -d |
There was a problem hiding this comment.
is host_override/compose.gae1.override.yml something that lives on the GAE, as I don't see it in the repo? Is it possible for me to run the external stack locally and have PIXL system tests send telemetry to it?
| [http://localhost:3001](http://localhost:3001) and log in with the credentials set | ||
| for the `lgtm` service in [`docker-compose.yml`](./docker-compose.yml). | ||
|
|
||
| ### Using the external telemetry stack instead |
There was a problem hiding this comment.
nice. Do you think we should remove the lgtm service from the system tests, and only describe how to use the external stack?
2 participants
Description
This pull request updates the system test's OpenTelemetry configuration and documentation to support both a bundled LGTM (Grafana, Loki, Tempo, Mimir) observability stack and an external shared telemetry stack.
Type of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.squash and merge