Conversation
prokopyl
marked this pull request as ready for review
July 18, 2026 01:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement several new operations on
WindowHandle, allowing these to be performed from outside theWindowHandler:get_size: Allows you to fetch the window's size (in both physical and logical coordinates).resize: Resizes the window.suggest_fallback_scale_factor: Suggest a fallback scale factor for Baseview to use in case it couldn't get one. (Useful in older Win32 and some X11 configurations)This PR also removes the
WindowScalePolicyoption, which is now unneeded.