Unified window creation#287
Open
prokopyl wants to merge 9 commits into
Open
Conversation
prokopyl
force-pushed
the
unified-window-creation
branch
from
56e1b38 to
893b298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
Window::open_parentedandWindow::open_blockingfunctions, in favor of a singlecreate_windowfunction.Parenting is now done using the
with_parentmethod inWindowOpenOptions.To block the current thread until the window is closed (like
open_blocking), use the newrun_until_closed()method on theWindowHandletype, which consumes the window handle.This makes parenting and blocking now two orthogonal features, allowing users to e.g. create a floating window that still doesn't block the current thread (or a parented window that does).